[Webkit-unassigned] [Bug 121420] [Win] Compile errors in WebCore derived sources.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121420





--- Comment #11 from Brent Fulgham <bfulgham at webkit.org>  2013-09-16 08:58:15 PST ---
(From update of attachment 211782)
View in context: https://bugs.webkit.org/attachment.cgi?id=211782&action=review

>> Source/WebCore/dom/make_names.pl:755
>> +    print(F "    new (NotNull, (void*)&${lowerNamespace}NamespaceURI) AtomicString(${lowerNamespace}NS);\n");
> 
> We usually avoid C-Style casts in the code.

When SKIP_STATIC_CONSTRUCTORS_ON_GCC is defined, the types of these globals are non-const. For all other platforms, they are const.  This requires a combination of static_cast and const_cast, but it is dependent on the setting of this variable.

I think in this case, the old fashioned C-style cast is the most concise way of dealing with this.

>> Source/WebCore/dom/make_names.pl:866
>> +        print F "        { (void*)&$name$shortCamelType, *${name}Impl },\n";
> 
> Ditto.

Idem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.