[Webkit-unassigned] [Bug 121413] [ATK] Extends atk value interface to return proper checkbox states.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121413





--- Comment #7 from Krzysztof Czech <k.czech at samsung.com>  2013-09-16 05:04:43 PST ---
> > Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.cpp:39
> > +static float webkitAccessibleValueGetCurrentValue(AccessibilityObject* coreObject)
> 
> I would probably call this webkitAccessibleValueValueForAccessibilityObject(), to make it clearer from the caller (and to make it more explicit in the ChangeLog that you added a new function here)

Sounds good.
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:1038
> > +    if (role == SliderRole || role == SpinButtonRole || role == ScrollBarRole || role == ProgressIndicatorRole || role == CheckBoxRole)
> 
> I think we should replace this condition with (coreObject->supportsRangeValue() || coreObject->isCheckboxOrRadio())

This is nice, thanks.

Already corrected

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.