[Webkit-unassigned] [Bug 99618] [MathML] Implement the mmultiscripts tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99618





--- Comment #36 from Frédéric Wang <fred.wang at free.fr>  2013-09-14 03:07:02 PST ---
(In reply to comment #33)
> > Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:364
> > +RenderMathMLScriptsWrapper* RenderMathMLScriptsWrapper::createAnonymousWrapper(RenderMathMLScripts* renderObject, WrapperType type)
> 
> can we make this a PassRefPtr?

I tried to make the argument a PassRefPtr but got an error that RenderMathMLScripts does not implement deref. As I can see all the createAnonymous functions in rendering/ use raw pointers. However, there is a comment in RenderMathMLRow to make the return pointer a ref. Perhaps we can migrate the createAnonymous MathML functions to ref counted pointers in a separate bug?

> 
> > Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:423
> > +            destroy();
> 
> is this going to destroy() this object?

Not the C++ destructor, but that will clean up all its data, I think. In particular that's why I get the parent node in RenderMathMLScriptsWrapper::addChild before calling addChildInternal. Without that, if I create/delete many nodes with attachment 208488, then I get memory leaks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.