[Webkit-unassigned] [Bug 121212] WinLauncher needs back and forward buttons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121212





--- Comment #5 from Alex Christensen <alex.christensen at flexsim.com>  2013-09-12 10:02:24 PST ---
I'll finish this next week.  I've got to finish lots of homework so I can go to Tahoe this weekend :)

> > Tools/WinLauncher/WinLauncher.cpp:90
> > +LRESULT CALLBACK    MyReloadButtonProc(HWND, UINT, WPARAM, LPARAM);
> 
> Can we please call these something else? The 'My...' Naming makes it seem like a programming class project! :)
I'll rename MyEditProc, too.

> > Tools/WinLauncher/WinLauncher.cpp:394
> > +    DefButtonProc = reinterpret_cast<WNDPROC>(GetWindowLongPtr(hBackButtonWnd, GWLP_WNDPROC));
> 
> Honestly, I'm surprised that the GetWindowLongPtr isn't defined as a 32/64 type based on compiler settings. Can you double check that this is necessary? I sort of think it could just be the ...Ptr version.
If I remember correctly, there was some issue with the WinCE not recognizing the ...Ptr functions.  I think WinCE is only 32-bit and only has the 32-bit functions.  Patrick?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.