[Webkit-unassigned] [Bug 120421] [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120421





--- Comment #15 from Christophe Dumez <dchris at gmail.com>  2013-09-12 09:44:06 PST ---
(From update of attachment 211426)
View in context: https://bugs.webkit.org/attachment.cgi?id=211426&action=review

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:51
> +    if (m_globalNotificationHandler)

Don't you mean the opposite?

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:53
> +    m_globalNotificationHandler->logAccessibilityEvents();

Weird that this does not crash

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:85
> +    String notificationName;

Couldn't this be a const char* ?

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:108
> +#if PLATFORM(GTK)

Why is this GTK-specific? Are we missing something in EFL?

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:169
> +#if PLATFORM(GTK)

Why no EFL?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.