[Webkit-unassigned] [Bug 120421] [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120421





--- Comment #12 from Denis Nomiyama (dnomi) <d.nomiyama at samsung.com>  2013-09-12 06:19:28 PST ---
(From update of attachment 211366)
View in context: https://bugs.webkit.org/attachment.cgi?id=211366&action=review

Many thanks for the comments. I will address the issues.

>> Tools/ChangeLog:3
>> +        [GTK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
> 
> This patch does not seem GTK-specific. Please use [ATK] flag instead.

Sure. I have changed the bug title and will update the ChangeLog.

>> Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:267
>> +#if PLATFORM(GTK) || PLATFORM(EFL)
> 
> #if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> 
> Ditto in the other places.

Ok. I'll fix them.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:52
>> +        m_globalNotificationHandler = adoptRef(new AccessibilityNotificationHandler);
> 
> Please use the factory method.

Ok. I'll change it.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:38
>> +    AccessibilityNotificationHandler(void);
> 
> Please make this constructor private and omit the "void". There is already a create() factory method.

Sure, I'll fix it.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:42
>> +    GRefPtr<AtkObject> platformElement(void) const { return m_platformElement; }
> 
> Ditto for the void

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.