[Webkit-unassigned] [Bug 120421] [GTK] Missing WTR AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120421





--- Comment #11 from Christophe Dumez <dchris at gmail.com>  2013-09-12 05:49:09 PST ---
(From update of attachment 211366)
View in context: https://bugs.webkit.org/attachment.cgi?id=211366&action=review

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:267
> +#if PLATFORM(GTK) || PLATFORM(EFL)

#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

Ditto in the other places.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:52
> +        m_globalNotificationHandler = adoptRef(new AccessibilityNotificationHandler);

Please use the factory method.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:38
> +    AccessibilityNotificationHandler(void);

Please make this constructor private and omit the "void". There is already a create() factory method.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:42
> +    GRefPtr<AtkObject> platformElement(void) const { return m_platformElement; }

Ditto for the void

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.