[Webkit-unassigned] [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117281


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211279|review?                     |review-
               Flag|                            |




--- Comment #60 from Geoffrey Garen <ggaren at apple.com>  2013-09-11 12:21:55 PST ---
(From update of attachment 211279)
View in context: https://bugs.webkit.org/attachment.cgi?id=211279&action=review

> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:571
> +    ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, FPRReg arg2, GPRReg arg3)
> +    {
> +        moveDouble(arg2, FPRInfo::argumentFPR0);
> +        move(arg3, GPRInfo::argumentGPR1);
> +        move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
> +    }
> +
> +    ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, GPRReg arg2, GPRReg arg3, FPRReg arg4)
> +    {
> +        moveDouble(arg4, FPRInfo::argumentFPR0);
> +        setupStubArguments(arg2, arg3);
> +        move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
> +    }

It looks like arg1 is unused in these functions. Is that a bug? I believe that shouldn't even build, due to the unused argument warning. Did you test this code on ARM_HARDFP?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.