[Webkit-unassigned] [Bug 120185] Port to Geoclue2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120185





--- Comment #11 from Anton Obzhirov <a.obzhirov at samsung.com>  2013-09-11 07:25:18 PST ---
I think it is good to (In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > (In reply to comment #7)
> > > > (In reply to comment #6)
> > > > > (In reply to comment #5)
> > > > > > (In reply to comment #4)
> > > > > > > Started working on geoclue2 provider.
> > > > > > 
> > > > > > Awesome. Would be really nice if all apps have already ported in 3.10 so distros don't have to keep shipping the old unmaintained code.
> > > > > 
> > > > > To be clear, I meant GNOME 3.10. :)
> > > > 
> > > > While implementing it got few questions for you:
> > > > 1) About accuracy - are you planning to add API to set accuracy level of the latitude and longitude coordinates?
> > > 
> > > If I understood your question correctly, no. This info is given from geoclue to app together with coordinates. Its accuracy of the location fix in meters. Currently its city-level at best. The app-writable 'DistanceThreshold' property is to specify the minimum distance changed before geoclue should notify your app.
> > 
> > Just for information you had this API for accuracy in geoclue:
> > /**
> >  * GeoclueAccuracyLevel:
> >  *
> >  * Enum values used to define the approximate accuracy of 
> >  * Position or Address information. These are ordered in
> >  * from lowest accuracy possible to highest accuracy possible.
> >  * geoclue_accuracy_get_details() can be used to get get the
> >  * current accuracy. It is up to the provider to set the
> >  * accuracy based on analysis of its queries.
> >  **/
> > typedef enum {
> >     GEOCLUE_ACCURACY_LEVEL_NONE = 0,
> >     GEOCLUE_ACCURACY_LEVEL_COUNTRY,
> >     GEOCLUE_ACCURACY_LEVEL_REGION,
> >     GEOCLUE_ACCURACY_LEVEL_LOCALITY,
> >     GEOCLUE_ACCURACY_LEVEL_POSTALCODE,
> >     GEOCLUE_ACCURACY_LEVEL_STREET,
> >     GEOCLUE_ACCURACY_LEVEL_DETAILED,
> > } GeoclueAccuracyLevel;
> > 
> > geoclue_master_client_set_requirements_*(, GeoclueAccuracyLevel, ...);
> 
> Ah! Its there in the design:
> 
>    enum RequestedAccuracy: accuracy level requested by the application
> 
> I can look into adding it today if you really need it?
>
Well it is not urgent but would be good to have for testing - I hope to get my change working by the end of this week.
> > > > 2) Same about timestamps - there is no way to obtain them now.
> > > 
> > > What kind of timestamps you need?
> > from the Geolocation spec: The length of time specified by the timeout property has elapsed before the implementation could successfully acquire a new Position. 
> > in geoclue https://developer.gnome.org/geoclue/unstable/GeocluePosition.html#GeocluePositionCallback has timestamp which I guess 
> > is abs time of acquiring the position. In geoclue2 I can calculate timestamps myself on LocationUpdated but it would be a bit in precise. But probably should be OK in most of the cases.
> 
> Ah ok but I'm still interested to find out if this info is actual useful for apps? If its for measuring speed, we have in the design to add 'speed' in geoclue2 so app won't have to do that.
As for the applications use cases I don't really know myself. May be someone else can comment here. I guess it can be used also to determine quality of the service (in terms of delays and so on) but again it is just my guess.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.