[Webkit-unassigned] [Bug 120783] Custom CSS cursors do not use -webkit-image-set on retina displays

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120783


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211167|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2013-09-10 12:56:39 PST ---
(From update of attachment 211167)
View in context: https://bugs.webkit.org/attachment.cgi?id=211167&action=review

> Source/WebCore/platform/mac/CursorMac.mm:56
> +    NSSize size = NSMakeSize(image->width() / scale, image->height() / scale);

Did you test with a cursor that has a non-integral pixel height? Like a 31x31 pixel cursor with a 2X scale factor?

> Source/WebKit2/ChangeLog:13
> +        (CoreIPC::::encode):
> +        (CoreIPC::::decode):

Should fix the incorrect function names here. It should be:

    (CoreIPC::ArgumentCoder<Cursor>::encode):

Too bad the script got it wrong, but it would be great if you fixed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.