[Webkit-unassigned] [Bug 98370] [GTK] accessibility/loading-iframe-sends-notification.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98370





--- Comment #3 from Mario Sanchez Prada <mario at webkit.org>  2013-09-10 09:37:38 PST ---
(From update of attachment 211203)
View in context: https://bugs.webkit.org/attachment.cgi?id=211203&action=review

> Source/WebCore/dom/Document.cpp:2463
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)

You probably want to comment on bug 112003 to let them that EFL platform might be just a single step away from fixing that bug (that is, adding here PLATFORM(EFL)). Not saying that you add it now, though.

> Source/WebCore/page/FrameView.cpp:1315
> +#if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(GTK)

Ditto.

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:109
> +        if (!g_strcmp0(g_value_get_string(&paramValues[1]), "layout-complete"))

I agree with Chris we might eventually switch into a "switch" statement, but in the meantime I would use here an "else if" for consistency with the rest of the code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.