[Webkit-unassigned] [Bug 120814] AX: Self-referencing aria-labelledby only uses contents.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120814





--- Comment #18 from Mario Sanchez Prada <mario at webkit.org>  2013-09-10 02:09:43 PST ---
(In reply to comment #13)
> [..]
> Thanks for the feedback!

No problem. Happy to help.

> > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1730
> > > -    if (isHTMLInputElement(node))
> > > -        return toHTMLInputElement(node)->value();
> > 
> > I'm not sure whether this removal is correct or not, since I 
> > can't see it covered in the new additions.
> 
> This bit covers the input element value case you mentioned.
> 
> +    const AtomicString& value = element->fastGetAttribute(valueAttr);
> +    if (!value.isEmpty())
> +        return value;

I'm not sure about it, since HTMLInputElement::value() does some more things besides returning the content of the 'value' attribute, such as sanitize the value:

    String HTMLInputElement::value() const
    {
        String value;
        if (m_inputType->getTypeSpecificValue(value))
            return value;

        value = m_valueIfDirty;
        if (!value.isNull())
            return value;

        AtomicString valueString = fastGetAttribute(valueAttr);
        value = sanitizeValue(valueString);
        if (!value.isNull())
            return value;

        return m_inputType->fallbackValue();
    }

Perhaps it will be worth it to keep a dedicated if branch for that specific situation?

> > Also, it might be interesting to test that everything keeps working
> > as expected for input elements as well
> 
> Good point. Added input element tests including value check mentioned above.

Thanks for considering it.

> I've moved the test here. Will see how the build bot responds and
> adapt results if needed.

Yes, I'll keep an eye on it in the GTK port

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.