[Webkit-unassigned] [Bug 93607] Web Inspector: [JSC] Caught exception is treated as uncaught

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93607


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211132|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Geoffrey Garen <ggaren at apple.com>  2013-09-09 21:23:53 PST ---
(From update of attachment 211132)
View in context: https://bugs.webkit.org/attachment.cgi?id=211132&action=review

Thanks, Joe!

r=me, but please fix the logic error below, and add a test for it.

> Source/JavaScriptCore/interpreter/Interpreter.cpp:582
> +        if (!codeBlock)
> +            return StackVisitor::Done;

I think you want StackVisitor::Continue here.

Consider this stack:
    js function with try/catch scope => Array.prototype.map => js function => throw
CodeBlock is null for host functions. Therefore, when you see Array.prototype.map, you'll return StackVisitor::Done and conclude that there's no handler. But there is a handler, in the function that called map.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.