[Webkit-unassigned] [Bug 120814] AX: Self-referencing aria-labelledby only uses contents.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120814





--- Comment #13 from Samuel White <samuel_white at apple.com>  2013-09-09 11:16:52 PST ---
(In reply to comment #11)
> (From update of attachment 210823 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210823&action=review
> 
> The patch looks quite good already, Just adding some comments below...

Thanks for the feedback!

> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1730
> > -    if (isHTMLInputElement(node))
> > -        return toHTMLInputElement(node)->value();
> 
> I'm not sure whether this removal is correct or not, since I can't see it covered in the new additions.

This bit covers the input element value case you mentioned.

+    const AtomicString& value = element->fastGetAttribute(valueAttr);
+    if (!value.isEmpty())
+        return value;

> 
> Also, it might be interesting to test that everything keeps working as expected for input elements as well

Good point. Added input element tests including value check mentioned above.

> 
> > LayoutTests/ChangeLog:11
> > +        * platform/mac/accessibility/self-referencing-aria-labelledby-expected.txt: Added.
> > +        * platform/mac/accessibility/self-referencing-aria-labelledby.html: Added.
> 
> I might be wrong, but I believe this new test could be perfectly placed in the general LayoutTests/accessibility directory, since it's a generic enough behaviour that should work fine in other platforms like GTK/EFL (maybe they will need some adapted results, but the test itself should be fine)

I've moved the test here. Will see how the build bot responds and adapt results if needed.

Thank again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.