[Webkit-unassigned] [Bug 120979] Separate forward and backward paths in ComposedShadowTreeWalker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120979


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210937|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-09-07 17:16:51 PST ---
(From update of attachment 210937)
View in context: https://bugs.webkit.org/attachment.cgi?id=210937&action=review

r=me. Almost there eh?

> Source/WebCore/dom/ComposedShadowTreeWalker.cpp:131
> +    ASSERT(node);
> +    ASSERT(node);

Maybe you should also assert that 'node' is non-null here.

> Source/WebCore/dom/ComposedShadowTreeWalker.cpp:150
>      ASSERT(node);
> -    if (Node* found = traverseSiblings(direction == TraversalDirectionForward ? node->nextSibling() : node->previousSibling(), direction))
> -        return found;
> -    return escapeFallbackContentElement(node, direction);
> +    ASSERT(node);

And here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.