[Webkit-unassigned] [Bug 120811] Get MEDIA_STREAM compiling for other ports (EFL and GTK)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120811


Zan Dobersek <zandobersek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zandobersek at gmail.com




--- Comment #6 from Zan Dobersek <zandobersek at gmail.com>  2013-09-06 02:34:32 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 210687 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=210687&action=review
> > 
> > > Source/WebCore/Modules/mediastream/LocalMediaStream.h:39
> > > +#if PLATFORM(MAC)
> > >  class LocalMediaStream FINAL : public MediaStream {
> > > +#else
> > > +class LocalMediaStream : public MediaStream {
> > > +#endif
> > 
> > Why doesn't FINAL work for you?
> 
> Because both LocalMediaStream and RTCStatsResponseBase in the end will be inherited by struct Base in JSDOMBinding.h (line 540)

I guess you mean the definition of the Base struct in the HasMemoryCostMemberFunction class?
http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/JSDOMBinding.h#L613

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.