[Webkit-unassigned] [Bug 120811] Get MEDIA_STREAM compiling for other ports (EFL and GTK)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120811





--- Comment #4 from Thiago de Barros Lacerda <thiago.lacerda at openbossa.org>  2013-09-05 20:08:20 PST ---
(In reply to comment #3)
> (From update of attachment 210687 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210687&action=review
> 
> > Source/WebCore/Modules/mediastream/LocalMediaStream.h:39
> > +#if PLATFORM(MAC)
> >  class LocalMediaStream FINAL : public MediaStream {
> > +#else
> > +class LocalMediaStream : public MediaStream {
> > +#endif
> 
> Why doesn't FINAL work for you?

Because both LocalMediaStream and RTCStatsResponseBase in the end will be inherited by struct Base in JSDOMBinding.h (line 540)

> 
> > Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp:60
> > +    RefPtr<MediaStreamDescriptor> descriptor = m_streamDescriptors.get(url);
> > +    return descriptor.get();
> 
> This is wrong, for HashMap the peek type is the wrapped pointer so you can just remove the ".get()":
> 
>   return m_streamDescriptors.get(url)
> 
My first thought was doing this way you are telling, but I thought it was wrong. OK, I will change.

> > Source/WebCore/Modules/mediastream/RTCStatsResponse.h:46
> > +#if PLATFORM(MAC)
> >  class RTCStatsResponse FINAL : public RTCStatsResponseBase {
> > +#else
> > +class RTCStatsResponse : public RTCStatsResponseBase {
> > +#endif
> 
> Why doesn't FINAL work here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.