[Webkit-unassigned] [Bug 120811] Get MEDIA_STREAM compiling for other ports (EFL and GTK)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120811





--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2013-09-05 17:32:07 PST ---
(From update of attachment 210687)
View in context: https://bugs.webkit.org/attachment.cgi?id=210687&action=review

> Source/WebCore/Modules/mediastream/LocalMediaStream.h:39
> +#if PLATFORM(MAC)
>  class LocalMediaStream FINAL : public MediaStream {
> +#else
> +class LocalMediaStream : public MediaStream {
> +#endif

Why doesn't FINAL work for you?

> Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp:60
> +    RefPtr<MediaStreamDescriptor> descriptor = m_streamDescriptors.get(url);
> +    return descriptor.get();

This is wrong, for HashMap the peek type is the wrapped pointer so you can just remove the ".get()":

  return m_streamDescriptors.get(url)

> Source/WebCore/Modules/mediastream/RTCStatsResponse.h:46
> +#if PLATFORM(MAC)
>  class RTCStatsResponse FINAL : public RTCStatsResponseBase {
> +#else
> +class RTCStatsResponse : public RTCStatsResponseBase {
> +#endif

Why doesn't FINAL work here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.