[Webkit-unassigned] [Bug 120769] [CSSRegions] Selection focusNode set to the "region" block, instead of the "source" block

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120769





--- Comment #2 from Javier Fernandez <jfernandez at igalia.com>  2013-09-05 10:02:34 PST ---
Created an attachment (id=210629)
 --> (https://bugs.webkit.org/attachment.cgi?id=210629&action=review)
WIP patch (no review needed)

This patch solves most of the issues related to the positionForPoint implementation for CSS Regions. there are still some problems when selection overflows rightwards, causing the remaining lines to be selected.

The patch uses the dom:Range defined for each RenderRegion instance. I was wondering whether it should be more elegant (not sure about efficiency yet) to determine the RenderBlock associated to the RenderRegion in the corresponding RenderFlowThred; hence, we could, I think, execute the rest of the code already implemented in the positionForPoint method. I mean, instead of getting the Position from the DOM nodes, using the lastRenderBox approach already implemented.

If we prefer to go that way, the question is: is there any way to get the RenderBlock child in the corresponding RenderFlowThread, associated to a RenderRegion ? I saw there are Maps and List to implement the opposite association, determining the RenderRegion associated to a RenderBlock. Im thinking on implementing a new Map/List associating the RenderBlock to the corresponding RenderRegion; do you think it makes sense ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.