[Webkit-unassigned] [Bug 117405] [EFL]Background Style of element not visible because of default theme style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117405





--- Comment #35 from Ryuan Choi <ryuan.choi at samsung.com>  2013-09-04 18:11:06 PST ---
(In reply to comment #33)
> > > Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:104
> > > +            if(get_int(styled) == 1) {
> > > +                new state[30];
> > > +                new Float:v;
> > > +                get_state(PART:"combo", state, 30, v);
> > > +                if(strcmp(state, "default")) {
> > > +                    set_state(PART:"combo", "default_styled", 0.0);
> > > +                    set_state(PART:"combo_button", "default_styled", 0.0);
> > > +                }
> > > +                if(strcmp(state, "disabled")) {
> > > +                    set_state(PART:"combo", "disabled_styled", 0.0);
> > > +                    set_state(PART:"combo_button", "disabled_styled", 0.0);
> > > +                }
> > > +                if(strcmp(state, "focused")) {
> > > +                    set_state(PART:"combo", "focused_styled", 0.0);
> > > +                    set_state(PART:"combo_button", "focused_styled", 0.0);
> > > +                }
> > > +                if(strcmp(state, "hovered")) {
> > > +                    set_state(PART:"combo", "hovered_styled", 0.0);
> > > +                    set_state(PART:"combo_button", "hovered_styled", 0.0);
> > > +                }
> > > +                if(strcmp(state, "pressed")) {
> > > +                    set_state(PART:"combo", "pressed_styled", 0.0);
> > > +                    set_state(PART:"combo_button", "pressed_styled", 0.0);
> > > +                }
> > > +            }
> > 
> > What if focused with disabled?
> In disabled case there is only one case: disabled, no disabled +  focus/press/hover   in original implementation also.
> > I think that some state may have priority.
> Current patch behavior is no different than original except transparent image.
> original implementation has no priority kind of states.
> 

OK, I misread it.
Because you compare applied state, priority is meaningless.

View in context: https://bugs.webkit.org/attachment.cgi?id=210368&action=review
> Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc:41
> +        image: "widget/combo/combo_normal_transparent.png" COMP;
> +        image: "widget/combo/combo_normal_button_transparent.png" COMP;
> +        image: "widget/combo/combo_hover_transparent.png" COMP;
> +        image: "widget/combo/combo_hover_button_transparent.png" COMP;
> +        image: "widget/combo/combo_focus_transparent.png" COMP;
> +        image: "widget/combo/combo_focus_button_transparent.png" COMP;
> +        image: "widget/combo/combo_press_transparent.png" COMP;
> +        image: "widget/combo/combo_press_button_transparent.png" COMP;

You also have to add these files into dependency list in Source/WebCore/platform/efl/DefaultTheme/CMakeLists.txt

And did you also check other layout test cases?

Others looks fine to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.