[Webkit-unassigned] [Bug 120397] Replace node() calls with generatingNode() for RenderRegion code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120397





--- Comment #8 from Mihnea Ovidenie <mihnea at adobe.com>  2013-09-04 11:20:33 PST ---
(In reply to comment #7)
> (From update of attachment 210466 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210466&action=review
> 
> > Source/WebCore/rendering/RenderRegion.h:40
> >  struct LayerFragment;
> >  typedef Vector<LayerFragment, 1> LayerFragments;
> 
> These should not be in the same paragraph as the straight class definitions. (Can fix that later, just something I noticed).

I will that later.

> 
> > Source/WebCore/rendering/RenderRegion.h:156
> > +    Element* generatingElement() const { return toElement(RenderObject::generatingNode()); }
> 
> Can this be zero? If not, it should return a reference.

It should not be 0, i can't think of any situation.

> 
> > Source/WebCore/rendering/RenderTreeAsText.cpp:673
> > +            String tagName = getTagName(renderRegion->node());
> 
> Why using node() here instead of generatingElement or generatingNode?

Because for pseudo-elements as regions i want pseudo to be printed instead of div, to have an indication that this is a region from a pseudo-element. I had a note in the second patch Changelog for that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.