[Webkit-unassigned] [Bug 120397] Replace node() calls with generatingNode() for RenderRegion code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 4 09:24:53 PDT 2013


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #210466|review?                     |review+
               Flag|                            |

--- Comment #7 from Darin Adler <darin at apple.com>  2013-09-04 09:24:10 PST ---
(From update of attachment 210466)
View in context: https://bugs.webkit.org/attachment.cgi?id=210466&action=review

> Source/WebCore/rendering/RenderRegion.h:40
>  struct LayerFragment;
>  typedef Vector<LayerFragment, 1> LayerFragments;

These should not be in the same paragraph as the straight class definitions. (Can fix that later, just something I noticed).

> Source/WebCore/rendering/RenderRegion.h:156
> +    Element* generatingElement() const { return toElement(RenderObject::generatingNode()); }

Can this be zero? If not, it should return a reference.

> Source/WebCore/rendering/RenderTreeAsText.cpp:673
> +            String tagName = getTagName(renderRegion->node());

Why using node() here instead of generatingElement or generatingNode?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list