[Webkit-unassigned] [Bug 120397] Replace node() calls with generatingNode() for RenderRegion code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120397


Mihnea Ovidenie <mihnea at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mihnea at adobe.com




--- Comment #6 from Mihnea Ovidenie <mihnea at adobe.com>  2013-09-04 09:10:05 PST ---
(In reply to comment #4)
> (From update of attachment 210433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210433&action=review
> 
> > Source/WebCore/rendering/RenderRegion.h:147
> > +    Element* generatingNodeForRegion() const;
> 
> This should be inlined; we don’t want function call overhead for what should be a free typecast. This should be called generatingElement, not generatedNodeForRegion.

Done, thanks for the name, generatingElement is much better than my solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.