[Webkit-unassigned] [Bug 120196] [Gtk][WK2] Use a permission-request for fullscreen requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120196





--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-09-04 08:40:10 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > > This is a good point, permission-request api is async, I think the internal fullscreen api is sync and that's probably the reason why we decided to use the enter/leave signals
> > 
> > So can I change the name of the bug and submit a patch to correct the documentation?
> 
> As the one who wrote the original (and misleding) documentation, I think this might be a good idea :)
> 
> When we wrote that we were thinking on examples that might make sense, and at that time the fullscreen thing looked like one of those, but after this discussion it seems obvious it's not the case so it's probably better to remove it from there to avoid more confusion.

Well, I'm not sure, after reading the code in more detail, the fullscreen client C API implementation is GTK+ specific, so we can change it to make it async if we want. Maybe we can have a permission request object that tells you whether it's entering or leaving fullscreen that allows you to use a non-modal dialog in the UI. We can leave the signals as just notifications, for people not handling the permission-request signal, for example, and still checking the return value for backwards compatibility. The only problem is that current signal names are not appropriate for notifications, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.