[Webkit-unassigned] [Bug 120626] [CSS Masking] -webkit-mask-origin should have an initial value of padding-box

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 10:21:27 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=120626





--- Comment #8 from Dirk Schulze <krit at webkit.org>  2013-09-03 10:20:45 PST ---
(In reply to comment #7)
> (In reply to comment #4)
> > (From update of attachment 210349 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=210349&action=review
> > 
> > > Source/WebCore/rendering/style/FillLayer.h:180
> > > -    static EFillBox initialFillOrigin(EFillLayerType type) { return type == BackgroundFillLayer ? PaddingFillBox : BorderFillBox; }
> > > +    static EFillBox initialFillOrigin(EFillLayerType) { return PaddingFillBox; }
> > 
> > Well, this code explicitly checked for BackgroundFillLayer. If it is background, then it sets padding-box. Obviously the type can be different and then it is BorderFillBox. I assume that the other case is -webkit-background, which must stay as it is. If it is incorrect for masking, you may add MaskFillLayer to the condition (does MaskFillLayer even exist?)
> 
> EFillLayerType can be only BackgroundFillLayer or MaskFillLayer. Some of those tests are failing because they are presuming that mask-origin will is defaulted to border-box.

Hmm. I am not sure if we should fix it now, or when unprefixing then.

David do you know if there is content that relies on -webkit-mask-origin: border-bx as initial value?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list