[Webkit-unassigned] [Bug 120623] [CSS Masking/Background] Position property should be ignored when using repeat: space

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 3 08:28:19 PDT 2013


--- Comment #6 from Dirk Schulze <krit at webkit.org>  2013-09-03 08:27:38 PST ---
(From update of attachment 210370)
View in context: https://bugs.webkit.org/attachment.cgi?id=210370&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1353
> +        if (space) {

You are not checking for positive as suggested in the ChangeLog, but for zero. Negtative values would still enter the code path.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1358
> +            geometry.setSpaceSize(FloatSize(space, 0));
> +            geometry.setPhaseX(actualWidth ? actualWidth - roundToInt(computedXPosition + left) % actualWidth : 0);
> +        } else
> +            backgroundRepeatX = NoRepeatFill;

To be honest, I do not understand the code path good enough. I would have assumed that you check how many tiles fit into the paint area. If it is less than two... disable spacing and use background-position instead. Maybe the code path does it, but I don't see it. Can you elaborate more please?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list