[Webkit-unassigned] [Bug 120512] PositionIterator increment and decrement functions can be sped up by not iterating through nodes without renderers

Mon Sep 2 05:00:21 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=120512

--- Comment #8 from Vani Hegde <vani.hegde at samsung.com>  2013-09-02 04:59:40 PST ---
(In reply to comment #7)
> (From update of attachment 210070 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210070&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        No new tests as this is a code refactoring.
> 
> This is not a code refactoring. It’s a performance fix. We should be able to create a performance test showing the increased speed.

Thanks for the review Darin.

I spent sometime trying to write a performance test and I am stuck with the same.

I wrote a simple test

<!DOCTYPE html>
<html>
<head>
<script src="../resources/runner.js"></script>
<script>
function runTest() {
    function start() {
        document.execCommand("SelectAll");
    }

    function end() {
        document.execCommand("Unselect");
    }

    PerfTestRunner.measureRunsPerSecond({ run: start, done: end });
}
</script>
</head>
<body onload='runTest()'>
<div id="test">
<!--Some comment to iterate through-->
<div>First</div>
<!--Some comment to iterate through-->
<div>Next</div>
<!--Some comment to iterate through-->
</div>
</body>
</html>

When I directly run this HTML through browser(Ex: QtTestBrowser), it works fine.

But when I tried the same through script
Tools/Scripts/run-perf-tests --output-json-path=/home/vani.hegde/Desktop/perf_test_result/result.json PerformanceTests/Editing/position-iterator-performance-test.html

this fails and I get an error as below
Running 1 tests
Running Editing/position-iterator-performance-test.html (1 of 1)
ERROR: First
FAILED
Finished: 6.329886 s

And I could not resolve this. Not sure if I am missing something here. I would really appreciate some help on this.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.