[Webkit-unassigned] [Bug 120572] ASSERT if port don't have color picker implemenation by inheriting webcolorpicker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120572





--- Comment #4 from Santosh Mahto <santosh.ma at samsung.com>  2013-09-01 07:40:57 PST ---
(In reply to comment #3)
> (From update of attachment 210228 [details])
> This is not a useful assertion. Don’t turn on INPUT_TYPE_COLOR without implementing createColorPicker. An assertion is not a helpful way to go further with this. The null dereference happens on the next line of code!

 WK2 ports implement color picker as two way.
1. inherit WebColorPicker  --> 

2. register PageUIClient Callback   --> Currently EFL port has this and m_colorPicke return null and its crashing now. [EFL]https://bugs.webkit.org/show_bug.cgi?id=119120 try to move the implementaion accoroding to first procedure.

I had a thought 
we should put a assert  to have m_colorpicker at that point.
OR we can avoid crash by having null check
OR wait for 119120 to land 

What is your view??

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.