[Webkit-unassigned] [Bug 122103] [EFL] Changed expectation in accessibility/file-upload-button-stringvalue.html after r156532

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 30 07:43:55 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122103





--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-09-30 07:42:52 PST ---
(From update of attachment 212993)
View in context: https://bugs.webkit.org/attachment.cgi?id=212993&action=review

> LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:11
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: file1.txt
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: file1.txt
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected

Hrm... this is strange. It should keep reporting file1.txt here, instead of "No files selected". If that's not the case, and previously it used to output file1.txt for EFL-WK1, then there's a bug and the rebaseline would not be correct.

> LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:15
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: 2 files
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected

Same here. The "No files selected" part is probably right (assuming is what you see rendered on the browser besides the button when no selection has been made yet), but the change from "2 files" -> "No files selected" is definitely wrong and it's probably hiding a bug in EFL (it's working fine in GTK)

> LayoutTests/platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:15
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: (None)
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected
>  
>  Drag and drop a single file:
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: (None)
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected
>  
>  Drag and drop two files:
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: (None)
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected

These ones are probably right (again, assuming is what you see rendered on the browser besides the button when no selection has been made yet), since this test that not work ok in any platform yet, as far as I know

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list