[Webkit-unassigned] [Bug 122062] Web Inspector: content view in back/forward list multiple times won't restore earlier positions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122062


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212900|review?                     |review-
               Flag|                            |




--- Comment #5 from Timothy Hatcher <timothy at apple.com>  2013-09-28 08:52:10 PST ---
(From update of attachment 212900)
View in context: https://bugs.webkit.org/attachment.cgi?id=212900&action=review

Looks good. The Object.shallowEqual issue is the only big issue.

> Source/WebInspectorUI/UserInterface/BackForwardEntry.js:36
> +    restorePositions: function()

I think restoreCookie would be a better name. There is nothing about "positions" that this explicitly restores.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.