[Webkit-unassigned] [Bug 121121] Web Inspector: Make WebKitGTK+ port work with Eclipse chromedevtools plugin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121121


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211586|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2013-09-27 08:30:06 PST ---
(From update of attachment 211586)
View in context: https://bugs.webkit.org/attachment.cgi?id=211586&action=review

> Source/WebKit2/ChangeLog:12
> +        fails.

s/fails/fail/

> Source/WebKit2/ChangeLog:28
> +        This patch fix the issues by adding support for the missing fields and accepting requests

s/fix/fixes/

> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:128
> +
> +    // chromedevtools (http://code.google.com/p/chromedevtools) 0.3.8 expected JSON format:
> +    // {
> +    //  "title": "Foo",
> +    //  "url": "http://foo",
> +    //  "devtoolsFrontendUrl": "/Main.html?ws=localhost:9222/devtools/page/1",
> +    //  "webSocketDebuggerUrl": "ws://localhost:9222/devtools/page/1"
> +    // },
> +

This comment might be more useful if it comes before the response is built.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.