[Webkit-unassigned] [Bug 121558] [ATK] Protect entry points in the ATK wrapper against outdated render trees

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121558


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212582|0                           |1
        is obsolete|                            |
 Attachment #212582|review?                     |
               Flag|                            |
 Attachment #212695|                            |review?
               Flag|                            |




--- Comment #22 from Mario Sanchez Prada <mario at webkit.org>  2013-09-26 05:51:59 PST ---
Created an attachment (id=212695)
 --> (https://bugs.webkit.org/attachment.cgi?id=212695&action=review)
Patch proposal

Attaching new patch addressing the issues pointed out by Chris.

(In reply to comment #21)
> (In reply to comment #20)
> > (From update of attachment 212582 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=212582&action=review
> > 
> > > Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:38
> > > +#define returnIfObjectIsInvalid(webkitAccessible) G_STMT_START { \
> > 
> Ok. Another option would be to rename the method to returnIfAccessibleIsInvalid, or even returnIfWebKitAccessibleIsInvalid, but I guess just changing the parameter name should be enough.

Actually I think I really prefer returnIfWebKitAccessibleIsInvalid() since that way is clear that a WebKitAccessible (subclass of AtkObject) is expected. I changed that in this new patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.