[Webkit-unassigned] [Bug 121899] New: Optimize strings copies in srcset parser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 04:12:55 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=121899

           Summary: Optimize strings copies in srcset parser
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Images
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: romain.perier at gmail.com
                CC: benjamin at webkit.org


Images URLs are copied for each loop iteration during the parsing algorithm. This is important to avoid sharing the same buffer with "srcsetattribute" which might be removed after the attribute has been processed (outside of "bestFitSourceForImageAttributes")
A good optimization would be to use shadow copies during parsing and deep copies when the selection algorithm returns the good candidate (as "srcsetAttribute" is not out of scope, this string is valid as long as the function "bestFitSourceForImageAttributes" runs)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list