[Webkit-unassigned] [Bug 111986] [EFL] accessibility/aria-invalid is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111986


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212339|review?                     |review-
               Flag|                            |




--- Comment #4 from Mario Sanchez Prada <mario at webkit.org>  2013-09-23 03:59:28 PST ---
(From update of attachment 212339)
View in context: https://bugs.webkit.org/attachment.cgi?id=212339&action=review

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:131
> +#elif PLATFORM(EFL) && HAVE(ACCESSIBILITY)

The whole content of this file is wrapper inside an HAVE(ACCESSIBILITY) guard, so you don't need to add it explicitly here.

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:232
> +#elif PLATFORM(EFL) && HAVE(ACCESSIBILITY)

Same here

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:266
> +#elif PLATFORM(EFL) && HAVE(ACCESSIBILITY)

And here :)

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:116
> +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))

In this case is different because this file is not guarded at all as the other ones.

Perhaps we should do it here too? After all, this file does not make much sense at all if you don't have accessibility enabled, does it? :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.