[Webkit-unassigned] [Bug 85994] [GStreamer] Source element fails with .ogg files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 23 00:01:57 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=85994





--- Comment #38 from Sergio Villar Senin <svillar at igalia.com>  2013-09-23 00:00:58 PST ---
(From update of attachment 212178)
View in context: https://bugs.webkit.org/attachment.cgi?id=212178&action=review

Looks like the patch is a step ahead but I miss some testing, we do not want to regress it in the future.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:942
> +    if (length > 0 && priv->requestedOffset && response.httpStatusCode() != 200)

I guess we should use == 206 here instead...

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1053
> +        }

Not sure this is correct. AFAIK the server might return a valid range in the request even if it's smaller than the one we requested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list