[Webkit-unassigned] [Bug 121712] New: VS2010 IDOM name clash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121712

           Summary: VS2010 IDOM name clash
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Windows 7
            Status: UNCONFIRMED
          Severity: Critical
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: alex.christensen at flexsim.com
                CC: bfulgham at webkit.org, roger_fong at apple.com


As of 8/26/2013, Microsoft has introduced documented IDOM interfaces in the Windows SDK with names that are the same as ours!  I got WebKit to compile with VS2012, but these are the interfaces I had to rename:

IDOMEvent                 http://msdn.microsoft.com/en-us/library/ff975965(v=vs.85).aspx
IDOMKeyboardEvent         http://msdn.microsoft.com/en-us/library/ff975944(v=vs.85).aspx
IDOMMouseEvent            http://msdn.microsoft.com/en-us/library/ff975920(v=vs.85).aspx
IDOMMutationEvent         http://msdn.microsoft.com/en-us/library/ff975904(v=vs.85).aspx
IDOMWheelEvent            http://msdn.microsoft.com/en-us/library/ff975846(v=vs.85).aspx
IDOMUIEvent               http://msdn.microsoft.com/en-us/library/ff975849(v=vs.85).aspx
IDOMDocumentType          http://msdn.microsoft.com/en-us/library/ff975979(v=vs.85).aspx
IDOMProcessingInstruction http://msdn.microsoft.com/en-us/library/ff975887(v=vs.85).aspx

I'm not sure if it's best to rename our IDOM interfaces that clash (which might require downstream changes if anyone uses these interfaces directly) or to use the Microsoft interfaces (which is outside of my expertise), but here's a patch that appends "WK" to the clashing names.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.