[Webkit-unassigned] [Bug 121565] New: AX: Notification tests shouldn't call waitUntilDone/notifyDone explicitly.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 18 12:59:02 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=121565

           Summary: AX: Notification tests shouldn't call
                    waitUntilDone/notifyDone explicitly.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: samuel_white at apple.com
                CC: webkit-bug-importer at group.apple.com


The following accessibility notification related tests are mixing explicit calls to waitUntilDone()/notifyDone() and setting window.jsTestIsAsync to true and calling finishJSTest(). Including the pre and post headers and setting window.jsTestIsAsync to true and calling finishJSTest is all that is actually needed as this will lead to waitUntilDone/notifyDone being called. We should clean these tests up so they are easier to follow and so others don't follow this incorrect mix and match pattern in the future.

LayoutTests/accessibility/aria-checkbox-sends-notification.html
LayoutTests/accessibility/aria-invalid.html
LayoutTests/accessibility/loading-iframe-sends-notification.html
LayoutTests/accessibility/menu-list-sends-change-notification.html
LayoutTests/accessibility/multiselect-list-reports-active-option.html
LayoutTests/accessibility/notification-listeners.html
LayoutTests/platform/iphone-simulator/accessibility/focus-change-notifications.html
LayoutTests/platform/mac/accessibility/aria-expanded-notifications.html
LayoutTests/platform/mac/accessibility/aria-listbox-selectedchildren-change.html
LayoutTests/platform/mac/accessibility/aria-liveregion-on-image.html
LayoutTests/platform/mac/accessibility/aria-liveregions-addedelement.html
LayoutTests/platform/mac/accessibility/aria-liveregions-changedalt.html
LayoutTests/platform/mac/accessibility/aria-liveregions-changedtext.html
LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html
LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html
LayoutTests/platform/mac/accessibility/aria-liveregions-removedelement.html
LayoutTests/platform/mac/accessibility/change-notification-on-scroll.html
LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html
LayoutTests/platform/mac/accessibility/html-slider-indicator.html
LayoutTests/platform/mac/accessibility/selected-rows-table.html
LayoutTests/platform/mac/accessibility/selection-value-changes-for-aria-textbox.html
LayoutTests/platform/mac/accessibility/textbox-role-reports-notifications.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list