[Webkit-unassigned] [Bug 120668] [CSS Background] repeat: round should round the number of tiles to the nearest natural number

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120668


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211880|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2013-09-17 08:55:08 PST ---
(From update of attachment 211880)
View in context: https://bugs.webkit.org/attachment.cgi?id=211880&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1129
> +        int nrTiles = static_cast<int>(round((float)positioningAreaSize.width() / fillTileSize.width()));

I believe the round function takes, and returns, a double. So casting to float and then calling round doesn't make good sense. If we want to use float, then it should be roundf, or if we want to stay with double, we should cast to double, not float.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.