[Webkit-unassigned] [Bug 121382] Web Inspector: TypeError when updating ResourceTreeElement created in strange order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121382





--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org>  2013-09-16 12:02:58 PST ---
(In reply to comment #6)
> (From update of attachment 211811 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211811&action=review
> 
> > Source/WebInspectorUI/UserInterface/ResourceTreeElement.js:-175
> > -    _updateStatusWithMainFrameButtons: function()
> > -    {
> > -        if (this._reloadButton) {
> > -            this.status = this._reloadButton;
> > -            return;
> > -        }
> > -
> > -        if (!this._loadingMainFrameButtons) {
> > -            this._loadingMainFrameButtons = true;
> > -            var tooltip = WebInspector.UIString("Reload page (%s)\nReload ignoring cache (%s)").format(WebInspector._reloadPageKeyboardShortcut.displayName, WebInspector._reloadPageIgnoringCacheKeyboardShortcut.displayName);
> > -            wrappedSVGDocument("Images/Reload.svg", "reload-button", tooltip, function(svgDocument) {
> > -                this._reloadButton = svgDocument;
> > -                this._reloadButton.addEventListener("click", this._reloadPageClicked);
> > -                this.status = this._reloadButton;
> > -                delete this._loadingMainFrameButtons;
> > -            }.bind(this));
> > -        }
> > -    },
> 
> Change log doesn’t mentioned this deletion.

I guess that is a prepare-ChangeLog issue. This function is unused code that should have been removed when we switched to "updateStatusForMainFrame".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.