[Webkit-unassigned] [Bug 99065] [GStreamer] Add support for Media Source API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 16 06:42:30 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=99065
--- Comment #27 from WebKit Commit Bot <commit-queue at webkit.org> 2013-09-16 06:41:35 PST ---
Attachment 211776 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/mediasource/MediaSource.cpp', u'Source/WebCore/Modules/mediasource/MediaSourceRegistry.cpp', u'Source/WebCore/Modules/mediasource/SourceBuffer.h', u'Source/WebCore/Modules/mediasource/SourceBufferList.h', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.pri', u'Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/MediaSourceGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/MediaSourceGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h', u'Source/WebCore/platform/qt/MIMETypeRegistryQt.cpp']" exit_code: 1
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h:50: webkit_media_src_get_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h:56: Do not use 'using namespace WebCore;'. [build/using_namespace] [4]
Source/WebCore/Modules/mediasource/SourceBuffer.h:40: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:92: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:93: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:94: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:152: webkit_media_src_class_init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:184: webkit_media_src_init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Source/WebCore/platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:254: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 9 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list