[Webkit-unassigned] [Bug 121369] New: [GTK] GObject DOM bindings for Console::profile(), Console::profileEnd() are improperly generated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 14 14:04:24 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=121369

           Summary: [GTK] GObject DOM bindings for Console::profile(),
                    Console::profileEnd() are improperly generated
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zandobersek at gmail.com
                CC: cgarcia at igalia.com, berto at igalia.com


This became a problem with changes in r155774, with the Console methods now taking JSC::ExecState as the first argument.
http://trac.webkit.org/changeset/155774

These are the generated bindings functions, causing compilation failures:
void
webkit_dom_console_profile(WebKitDOMConsole* self, const gchar* title)
{
#if ENABLE(JAVASCRIPT_DEBUGGER)
    WebCore::JSMainThreadNullState state;
    g_return_if_fail(WEBKIT_DOM_IS_CONSOLE(self));
    g_return_if_fail(title);
    WebCore::Console* item = WebKit::core(self);
    WTF::String convertedTitle = WTF::String::fromUTF8(title);
    item->profile(convertedTitle);
#else
    WEBKIT_WARN_FEATURE_NOT_PRESENT("Javascript Debugger")
#endif /* ENABLE(JAVASCRIPT_DEBUGGER) */
}

void
webkit_dom_console_profile_end(WebKitDOMConsole* self, const gchar* title)
{
#if ENABLE(JAVASCRIPT_DEBUGGER)
    WebCore::JSMainThreadNullState state;
    g_return_if_fail(WEBKIT_DOM_IS_CONSOLE(self));
    g_return_if_fail(title);
    WebCore::Console* item = WebKit::core(self);
    WTF::String convertedTitle = WTF::String::fromUTF8(title);
    item->profileEnd(convertedTitle);
#else
    WEBKIT_WARN_FEATURE_NOT_PRESENT("Javascript Debugger")
#endif /* ENABLE(JAVASCRIPT_DEBUGGER) */
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list