[Webkit-unassigned] [Bug 120421] [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120421





--- Comment #16 from Denis Nomiyama (dnomi) <d.nomiyama at samsung.com>  2013-09-13 07:39:20 PST ---
(From update of attachment 211426)
View in context: https://bugs.webkit.org/attachment.cgi?id=211426&action=review

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:51
>> +    if (m_globalNotificationHandler)
> 
> Don't you mean the opposite?

Ops, yes. I'll fix it.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:53
>> +    m_globalNotificationHandler->logAccessibilityEvents();
> 
> Weird that this does not crash

The pointer is ok, but a new global handler is created every time the logging is enabled.. I'll fix it.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:85
>> +    String notificationName;
> 
> Couldn't this be a const char* ?

True and it makes the code simpler and quicker. I'll give it a try.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:108
>> +#if PLATFORM(GTK)
> 
> Why is this GTK-specific? Are we missing something in EFL?

I'm not able to test the EFL port to ensure this also works on EFL. I'm planning to raise a bug to let EFL engineers know about it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.