[Webkit-unassigned] [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117281





--- Comment #68 from Youngho Yoo <youngho33.yoo at lge.com>  2013-09-11 23:10:49 PST ---
(In reply to comment #67)
> (In reply to comment #63)
> > (In reply to comment #61)
> > > (In reply to comment #60)
> > > > (From update of attachment 211279 [details] [details] [details] [details])
> > > > View in context: https://bugs.webkit.org/attachment.cgi?id=211279&action=review
> > > > 
> > > > > Source/JavaScriptCore/dfg/DFGCCallHelpers.h:571
> > > > > +    ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, FPRReg arg2, GPRReg arg3)
> > > > > +    {
> > > > > +        moveDouble(arg2, FPRInfo::argumentFPR0);
> > > > > +        move(arg3, GPRInfo::argumentGPR1);
> > > > > +        move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
> > > > > +    }
> > > > > +
> > > > > +    ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, GPRReg arg2, GPRReg arg3, FPRReg arg4)
> > > > > +    {
> > > > > +        moveDouble(arg4, FPRInfo::argumentFPR0);
> > > > > +        setupStubArguments(arg2, arg3);
> > > > > +        move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
> > > > > +    }
> > > > 
> > > > It looks like arg1 is unused in these functions. Is that a bug? I believe that shouldn't even build, due to the unused argument warning. Did you test this code on ARM_HARDFP?
> > > 
> > > You are right, these two functions are the EABI_32BIT_DUMMY_ARG, ARM_HARDFP case.Then, How about use UNUSED_PARAM(arg1)?
> > 
> > Use UNUSED_PARAM(arg1).
> 
> Better yet just omit the 'arg1' name.  Say:
> 
> ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32, GPRReg arg2, GPRReg arg3, FPRReg arg4)
> 
> Instead of:
> 
> ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImm32 arg1, GPRReg arg2, GPRReg arg3, FPRReg arg4)
> 
> > 
> > Is there any concern that the argument registers are the same as the argumentGPRN?  Seems like this could be the case since ARM has a limited number of registers.

OK, It's much better. I Think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.