[Webkit-unassigned] [Bug 121212] WinLauncher needs back and forward buttons

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 11 22:40:18 PDT 2013


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #211399|review?                     |review-
               Flag|                            |

--- Comment #4 from Brent Fulgham <bfulgham at webkit.org>  2013-09-11 22:39:30 PST ---
(From update of attachment 211399)
View in context: https://bugs.webkit.org/attachment.cgi?id=211399&action=review

Thanks for doing this. It will be ice to have these in the UI. r- so you don't delete hooks to some things I'm trying to get landed. :)

> Tools/WinLauncher/WinLauncher.cpp:90

Can we please call these something else? The 'My...' Naming makes it seem like a programming class project! :)

> Tools/WinLauncher/WinLauncher.cpp:379
> +                    hInst, 0);

Please format these normally with 4-space indents. One or two lines are better than these large blocks.

> Tools/WinLauncher/WinLauncher.cpp:394
> +    DefButtonProc = reinterpret_cast<WNDPROC>(GetWindowLongPtr(hBackButtonWnd, GWLP_WNDPROC));

Honestly, I'm surprised that the GetWindowLongPtr isn't defined as a 32/64 type based on compiler settings. Can you double check that this is necessary? I sort of think it could just be the ...Ptr version.

> Tools/WinLauncher/WinLauncher.cpp:-685
> -

Please don't delete this. It's WIP.

> Tools/WinLauncher/WinLauncher.cpp:-730
> -            break;

Leave in please.

> Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:-52
> -    END

Leave in please.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list