[Webkit-unassigned] [Bug 121189] New: check-webkit-style complains about "int" bitfield types.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121189

           Summary: check-webkit-style complains about "int" bitfield
                    types.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: ASSIGNED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: msaboff at apple.com


in Tools/Scripts/webkitpy/style/checkers/cpp.py around line 3110, we check to see whether a bitfield is declared with signed, unsigned or bool.  The check is done by looking for all the other types.

    # Check for plain bitfields declared without either "singed" or "unsigned".
    # Most compilers treat such bitfields as signed, but there are still compilers like
    # RVCT 4.0 that use unsigned by default.
    matched = re.match(r'\s*((const|mutable)\s+)?(char|(short(\s+int)?)|int|long(\s+(long|int))?)\s+[a-zA-Z_][a-zA-Z0-9_]*\s*:\s*\d+\s*;', line)

It seems a little strange that short, int and long types are on the "bad" list as these are clearly signed values.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.