[Webkit-unassigned] [Bug 120421] [GTK] Missing WTR AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120421





--- Comment #5 from chris fleizach <cfleizach at apple.com>  2013-09-11 11:59:10 PST ---
(From update of attachment 211337)
View in context: https://bugs.webkit.org/attachment.cgi?id=211337&action=review

> Tools/ChangeLog:77
> +2013-09-11  Denis Nomiyama  <d.nomiyama at samsung.com>

two change log entries

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:71
> +static gboolean axObjectEventListener(GSignalInvocationHint *signalHint, guint numParamValues, const GValue *paramValues, gpointer data)

* are on wrong side

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:74
> +    if (numParamValues < 1)

this looks like it should be if (!numParamValues) return

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:79
> +        return TRUE;

true instead of TRUE

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.