[Webkit-unassigned] [Bug 121170] New: RenderTextTrackContainerElement::layout() pretends to have done the layout, but postpones the work on a 0-delay timer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 11 11:04:09 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=121170

           Summary: RenderTextTrackContainerElement::layout() pretends to
                    have done the layout, but postpones the work on a
                    0-delay timer
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media Elements
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ap at webkit.org
                CC: koivisto at iki.fi, eric.carlson at apple.com,
                    simon.fraser at apple.com, rniwa at webkit.org,
                    jer.noble at apple.com
        Depends on: 121169


This causes flakiness on at least one test (bug 121169), and I expect this to be a general issue that affects many tests. Perhaps most of these are already marked as flaky or skipped.

RenderTextTrackContainerElement::layout() calls MediaControlTextTrackContainerElement::updateSizes(), which does some work, and delays other work on a zero delay timer! So by the time layout is done, text cue sizes are still wrong, they are only updated in updateTimerFired().

This zero delay timer cannot be simply removed, because it does a lot of work that's unsafe during layout, including DOM manipulation. While I don't know much about text tracks and/or layout, I have a strong feeling that it must be possible to do it differently.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list