[Webkit-unassigned] [Bug 120953] Remove unnecessary sibling text renderers after attach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 7 10:59:29 PDT 2013


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
 Attachment #210906|review?                     |review+
               Flag|                            |

--- Comment #3 from Anders Carlsson <andersca at apple.com>  2013-09-07 10:58:45 PST ---
(From update of attachment 210906)
View in context: https://bugs.webkit.org/attachment.cgi?id=210906&action=review

> Source/WebCore/ChangeLog:8
> +        The current createTextRenderersForSiblingsAfterAttachIfNeeded code only adds text renderers, never removes them. Style changes can  go either way.

Extra space before "go".

> Source/WebCore/style/StyleResolveTree.cpp:305
> +        bool hadRenderer = !!whitespaceTextSibling.renderer();

Do you really need the !! here?

> LayoutTests/editing/selection/focus-crash-expected.txt:1
> -To run this test manually, click the "Crash me" button. 
> +To run this test manually, click the "Crash me" button.  

What's with this test? Looks like it adds whitespace?

> LayoutTests/userscripts/user-script-all-frames-expected.txt:1
> +If any thingers appear on this page, the test has failed.  

Same here.

> LayoutTests/userscripts/user-script-top-frame-only-expected.txt:1
> +Two thingers should appear on this page. Otherwise the test has failed.  

And here!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list