[Webkit-unassigned] [Bug 120814] AX: Self-referencing aria-labelledby only uses contents.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120814





--- Comment #11 from Mario Sanchez Prada <mario at webkit.org>  2013-09-07 02:08:49 PST ---
(From update of attachment 210823)
View in context: https://bugs.webkit.org/attachment.cgi?id=210823&action=review

The patch looks quite good already, Just adding some comments below...

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1730
> -    if (isHTMLInputElement(node))
> -        return toHTMLInputElement(node)->value();

I'm not sure whether this removal is correct or not, since I can't see it covered in the new additions.

Also, it might be interesting to test that everything keeps working as expected for input elements as well

> LayoutTests/ChangeLog:11
> +        * platform/mac/accessibility/self-referencing-aria-labelledby-expected.txt: Added.
> +        * platform/mac/accessibility/self-referencing-aria-labelledby.html: Added.

I might be wrong, but I believe this new test could be perfectly placed in the general LayoutTests/accessibility directory, since it's a generic enough behaviour that should work fine in other platforms like GTK/EFL (maybe they will need some adapted results, but the test itself should be fine)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.