[Webkit-unassigned] [Bug 120814] AX: Self-referencing aria-labelledby only uses contents.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120814





--- Comment #8 from Darin Adler <darin at apple.com>  2013-09-06 14:00:59 PST ---
(From update of attachment 210765)
View in context: https://bugs.webkit.org/attachment.cgi?id=210765&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1725
> +    if (!node->isHTMLElement())
> +        return String();

Text nodes used to return their text. Why was this removed?

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1729
> +    const AtomicString& ariaLabel = element->getAttribute(aria_labelAttr);

These can be fastGetAttribute. The only time you can’t call fastGetAttribute is when the attribute is an attribute that SVG can animate or a style attribute.

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:-1748
> -        for (Node* n = idElement->firstChild(); n; n = NodeTraversal::next(n, idElement))
> -            builder.append(accessibleNameForNode(n));

What makes it OK to remove this loop? Nothing in change log mentions that.

> Source/WebCore/ChangeLog:11
> +        Test: platform/mac/accessibility/self-referencing-aria-labelledby.html

I don’t see any coverage for the text node parts of this patch in this test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.